Progress review agenda 23 August 2022
Hi @lathrops1 @Kireev @latternm @ErinS @deniskar @douglassue @jordandc @jeffbeckncbi
(cc @bela @danjela @DioneMentis @John.kopanas @pokhi @rudresh @Shanthi_B @shubtiwari @sidorelauku @vignesh03)
Update on release this week
The release this week will include:
URL | Title | Milestone | Labels |
---|---|---|---|
#403 (closed) |
XML workflow: Renaming book_pdf file with domain name |
2022-Jul-B | MVP deployment,QA:: ncbidev,feature,prod:: deploy 1 |
#804 | Inconsistent behaviour in permitting ingest of tagged XML from PDF | 2022-Jul-B | MVP deployment,QA:: ncbidev,UI,back-end,design improvement,scope:: approved |
#1219 (closed) | Special character: & not tagged properly | 2022-Jul-B | MVP deployment,QA:: ncbidev,bug,fix:: for deploy 1 |
#1374 (closed) | ampersand in copyright causes invalid xml | 2022-Aug | MVP deployment,QA:: ncbidev,bug |
#1311 (closed) | Inaccurate info button about where metadata comes from | 2022-Aug | QA:: ncbidev,UI,bug,release-20220810 |
#1357 (closed) | Lift requirement of file character limits | 2022-Aug | MVP deployment,QA:: ncbidev |
The release may include, depending on the outcomes and timing of the final stages of QA:
URL | Title | Milestone | Labels |
---|---|---|---|
#1177 (closed) | Unable to migrate multiple affiliations for chapter-processed book metadata | 2022-Jul-B | MVP deployment,QA:: passed,blocking: migration,design improvement,feature,needs changes,new requirements,prod:: deploy 1 |
#1184 (closed) | can preview and publish with empty "Book source type" | 2022-Jun-B | MVP deployment,QA:: passed,UI,blocking: testing,design improvement,fix:: for deploy 1,scope:: approved |
#1341 (closed) | "back" button navigation on collections seems to loop navigation | 2022-Aug | QA:: passed,bug |
#1344 (closed) | Fixes on publication date validations | 2022-Aug | MVP deployment,QA:: passed,UI,bug |
#1383 (closed) | Changes to file and extension matching for supplementary, support files | 2022-Aug | QA:: passed |
I would suggest we schedule the release for tomorrow to get as many of these in as possible, as well as possibly other issues which are still in early stages of QA.
MVP priorities
We have a few new issues added to the MVP list. Stacy and I should groom the list and prioritize them again this week.
Issues I'd like to discuss today
- #1383 (closed) in relation to review files. It was requested in #933 (closed), and opened in new issue #1383 (closed) based on that request, that we should expect that case is insensitive and:
- filenames are matched based on base filename, ignoring extension
- file versions are incremented based on base filename
We have done this in #1383 (closed) for supplementary and support files and in #1352 (closed) for image files. However review files work quite differently. As per our Wiki integration specs:
All files
All files, whether submitted in the UI or by FTP, must meet this base validation:
The filenames:
- should only contain letters, numbers, hyphens, dashes, periods, and underscores
- must not contain spaces
All files are versioned by filename excluding the extension. In other words, the version of an existing file is increased when a new file with the same filename is uploaded. The exception is Review files (those uploaded in the review panel on the Preview tab) which are not versioned.
I would like to understand if we need the same versioning for review files, and what the use case is, because that might require quite a bit of refactoring. Under the current implementation the following options are possible:
a) either always add review files as a new file (this is what we currently do)
b) replace the existing match with the new file
Alternatively we could possibly refactor review files to somehow support the same versioning as images, supplementary. and support files, but we should first determine if that is necessary before determining technical possibilities and approach.
- #1330 (closed): Add Environment variable which will show the BCMS login or will redirect to Login NCBI
We would like to understand the issue reported in #1330 (closed) and if that relates to NCBI or Coko work to develop. I think the issue relates to work Denis was involved in so is required to be fixed on NCBI's side.
Issues I'm busy scoping or documenting
#1346 (closed) (Advanced chapter level versioning and removing of versioning indicators at the book level)
Giannis and I are busy reviewing my update to the issue description and will tag Stacy to review when that is done, and once approved by Stacy I will send to Martin for review.
#1372 (closed) (Need support for contrib-group roles)
I am busy updating the issue description and will assign for sign-off once done.
#1378 (closed) (Support for processing instructions in chapter-processed books / collections)
I will extract the information into separate issues and assign them for sign-off.