Progress review agenda 2 August 2022
Hi @lathrops1 @Kireev @latternm @ErinS @deniskar @douglassue @jordandc @jeffbeckncbi
(cc @John.kopanas @danjela @DioneMentis @Shanthi_B @pokhi @shubtiwari @rudresh @sidorelauku @bela @vignesh03)
Here is the agenda for our review call today. NCBI team, if you would like to add anything to the agenda feel free to comment here.
Release update
We are set to do a release later which will include the following:
URL | Title | Milestone | Labels | Epic ID | Epic Title |
---|---|---|---|---|---|
#1185 (closed) | book publication date range not updating in metadata modal | 2022-July-A | MVP deployment,QA:: ncbidev,back-end,bug,fix:: for deploy 1,scope::weight | 56 | Meta Book (wholebook) |
#1251 (closed) | Vendor Meta file is not valid blocking FTP packages getting ingested to BCMS | 2022-Jul-B | MVP deployment,QA:: ncbidev,back-end,bug,fix:: for deploy 1 | 32 | PDF (book and chapter) integration |
#1303 (closed) | Unable to save metadata modal when having multiple grants | 2022-Jul-B | MVP deployment,QA:: ncbidev,blocking: testing,bug | ||
#1305 (closed) | Application crashed, logged me out, and now I can't log in | 2022-Jul-B | MVP deployment,QA:: ncbidev,blocking: testing,dev:: done | ||
#1321 (closed) | Inaccurate Component and File Status | 2022-Jul-B | MVP deployment,QA:: ncbidev,bug | ||
#1326 (closed) | New book doesn't show in collection after book metadata is updated | 2022-Jul-B | MVP deployment,QA:: ncbidev | 21 | Set up: Create Org, Collection, and Book |
The release may include the following depending on the outcomes of our final stages of QA carried out today:
URL | Title | Milestone | Labels | Epic ID | Epic Title |
---|---|---|---|---|---|
#982 (closed) | Grants applied directly to chapter components not written in to JSON sent in PMC ingest package | 2022-July-A | MVP deployment,QA:: passed,back-end,blocking: migration,bug,fix:: for deploy 1 | 51 | Meta Funding |
#992 (closed) | Submit, Reload preview, publish wholebooks in bulk in the collection manager | 2022-Mar-C | QA:: passed,feature,prod:: deploy 1,release-20220518 | 3 | Collection TOC management |
#1184 (closed) | can preview and publish with emtpy "Book source type" | 2022-Jun-B | MVP deployment,QA:: passed,UI,blocking: testing,design improvement,fix:: for deploy 1,scope:: approved | 57 | Meta template |
#1216 (closed) | Date format MM/YYYY-null/YYYY will automatically add a month for the null on converted files and TOC | 2022-May-B | QA:: passed | 55 | Meta Book (chapter-processed) |
#1232 (closed) | publication history allows non-digits in month field | 2022-May-B | QA:: passed,bug,fix:: for deploy 1,needs changes | 55 | Meta Book (chapter-processed) |
#1252 (closed) | Citation self-URL and Special publisher link URL need to support text string value of doi
|
2022-Jun-B | MVP deployment,QA:: passed,UI,design improvement,fix:: for deploy 1,release-20220726 | 48 | Setting: Org templates |
#1253 (closed) | Book Editor: Add permissions for drag and drop on book manager | 2022-Jun-B | QA:: passed,bug,fix:: for deploy 1 | ||
#1314 (closed) | Collection manager page goes blank when clicking the checkbox for wholebooks. | 2022-Jul-B | MVP deployment,QA:: passed,UI,bug | ||
#1315 (closed) | Publication date ranges should not support formats "null/YEAR-MM/YEAR" or "MM/YEAR-null/YEAR" | 2022-Jul-B | QA:: passed |
Depending on our QA progress today there is a slight chance we could decide to delay the release to tomorrow, to push as many issues out for testing this week as possible.
Remaining MVP issues
Progress of the following issues is stated in the last column.
URL | Title | Milestone | Labels | Epic ID | Epic Title | Status |
---|---|---|---|---|---|---|
#933 (closed) | Read OA status from converted file and add to PDF and XML wholebook metadata | 2022-July-A | MVP deployment,back-end,blocking: migration,design improvement,dev:: done,fix:: for deploy 1,release-20220726,scope:: approved | 56 | Meta Book (wholebook) | This is done but left open until NCBI determines the need and priority for supporting the NLM v2.3 DTD format, as related to #1186 (closed). |
#1276 (closed) | Collection grant 'Apply to all' toggle should be automatically off for all collections, and editable by Sys admins | MVP deployment,dev:: done,ncbi greenlight testing | 54 | Meta Collection | This is done but left open for final testing once #1281 (closed) is done. | |
#1281 (closed) | Permissions for Editors on Grants for Books and Book components. | 2022-Jun-B | MVP deployment,bug,dev:: QA fixes | 51 | Meta Funding | In QA |
#1078 (closed) | Should not be able to publish collection TOC with chapter-processed books in Published status but without any Published TOC | 2022-Jul-B | MVP deployment,QA:: to do,UI,back-end,design improvement,prod:: deploy 1 | 3 | Collection TOC management | In QA |
#1312 (closed) | User should not be able to create a negative version number or zero as a version number | 2022-Jul-B | MVP deployment,QA:: to do,bug | In QA | ||
#1327 (closed) | Incorrect Request when the bookComponent Page is loading | MVP deployment,dev:: done | In QA | |||
#804 | Inconsistent behavior in permitting ingest of tagged XML from PDF | 2022-Jul-B | MVP deployment,UI,back-end,design improvement,dev:: doing,notification,scope:: approved | 71 | Convert and load errors | In progress |
#403 (closed) |
XML workflow: Renaming book_pdf file with domain name |
2022-Jul-B | MVP deployment,feature,prod:: deploy 1 | 40 | FM Submit | In progress |
#1177 (closed) | Unable to migrate multiple affiliations for chapter-processed book metadata | 2022-Jul-B | MVP deployment,blocking: migration,design improvement,dev:: to do,feature,new requirements,prod:: deploy 1 | 55 | Meta Book (chapter-processed) | In progress |
#1286 (closed) | Support chat for whole books | 2022-Jul-B | MVP deployment,back-end,bug | 68 | Book Versions | In progress |
#1278 (closed) | No filename validation for XML and PDF wholebook converted files | 2022-July-A | MVP deployment,dev:: doing,scope:: approved | 35 | Files management | In progress |
#1302 (closed) | Book previews sometimes don't show the preview | 2022-Jul-B | MVP deployment,back-end,bug,dev:: QA fixes | In progress | ||
#1308 | Unable to create chapter published versions | 2022-Jul-B | MVP deployment,dev:: QA fixes | In progress | ||
#1149 | previously published chapter that is previewing does not show on toc | 2022-Jul-B | MVP deployment,back-end,bug,dev:: to do,fix:: for deploy 1,scope::weight | 2 | Chapter-processed TOC management | Next up |
#1219 (closed) | Special character: & not tagged properly | 2022-Jul-B | MVP deployment,bug,dev:: to do,fix:: for deploy 1 | 55 | Meta Book (chapter-processed) | Next up |
#481 (closed) | Agreements API request at Publish step | MVP deployment,back-end,dev:: to do,feature,prod:: deploy 1 | 28 | Publish | Might be delayed as it was determined by NCBI to be lower priority in the list of MVP priorities | |
#511 (closed) | Email notifications documentation | Documentation,MVP deployment,back-end,feature,prod:: deploy 1,scope:: review | 42 | FM Tracking | Might be delayed as it was determined by NCBI to be lower priority in the list of MVP priorities | |
#1275 (closed) | New Settings 'Override OA agreement status' and 'Override UKPMC agreement status' toggle | MVP deployment,UI,back-end,scope:: review | 22 | Set up: Settings | Might be delayed as it was determined by NCBI to be lower priority in the list of MVP priorities | |
#1151 (closed) | PDF First Match to Later Full Text Version | MVP deployment,blocking: migration,feature,prod:: deploy 1,release-20220719 | 68 | Book Versions | Under discussion to determine MVP approach | |
#1313 (closed) | Innacurate previews for inactive book versions | MVP deployment,NCBI dev task | Under discussion to determine MVP approach | |||
#1323 (closed) | Upload button not responding | MVP deployment,bug | In QA to reproduce |
Issues of concern
#1313 (closed): Inaccurate previews for inactive book versions
The expected behaviour is that "Previews displayed in preview tabs are accurate for the book version content."
The current behaviour is that PMC only supports one preview per wholebook, so each book only has one preview shared across the book versions, and displays the latest preview received for the book (corresponding to the book's version which was the last previewed version).
In order to display accurate previews for book versions, PMC would need to support multiple previews per wholebook, one for each version. This has not been developed on PMC side yet.
Any further development in the BCMS at this stage would be undoing ideal target desired functionality to workaround the current PMC limitation, and we'd have to undo all of that later when it is supported PMC-side. The solution would be to develop the related functionality on PMC-side to support book versions.
We can't restrict previews to only an 'active' version because we never scoped together or developed the notion of active, or restricting the user to only perform actions on active versions. We don't have a concept of active in book versions in the BCMS and we never planned together to have that. Investing effort in a workaround to circumvent the intended functionality at this stage is not a good use of time resources for the MVP and could lead to other bugs and undesired behaviour.
At most, for MVP, we could put a notice on all PDF and XML wholebook versions to say "All previews relate to the latest version loaded to preview."
Do you think the use case for MVP is strong enough to warrant adding that message at this stage?
#1332 (closed): BCMS "Organizations" multi-to-multi relationships and their related roles and permissions and workflows (particularly funding)
We received new information last night about this issue. We are working with the information provided and will then regroup with NCBI. It is still unclear if this new information will have any impact on the data model, but we are working to understand the future fields required to support user stories, and what that means for backward compatibility, migrating content, and determining a source of truth for content in the future.